Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lamdba): add admin function for NOSO 2 #1060

Merged
merged 23 commits into from
Jan 29, 2025
Merged

feat(lamdba): add admin function for NOSO 2 #1060

merged 23 commits into from
Jan 29, 2025

Conversation

andieswift
Copy link
Collaborator

@andieswift andieswift commented Jan 24, 2025 •
edited
Loading

The work done previously was in the wrong direction so I started over.

🎫 Linked Ticket

OY2-31182

💬 Description / Notes

Need to add the ability for an admin to run a lamdba for NOSOs to move over to mako

Submit NOSO

  1. In lamdba functions go to mako--api-submitNOSO
  2. Click Test and JSON should be formated like:
    { "body": { "id": "OH-96-0006", "authority": "Medicaid SPA", "status": "Submitted", "submitterEmail": "[email protected]", "submitterName": "George Harrison", "adminChangeType": "NOSO" } }

🛠 Changes

added an admin function for creating a new submissions for NOSOs

  • move change admin functions to their own folder
  • followed similar structure used for admin updatePackage

📸 Screenshots / Demo

Running the lamdba function
Screenshot 2025-01-23 at 7 59 59 PM

How the new package appears on dash
Screenshot 2025-01-23 at 7 58 25 PM

How the package appears on package details
Screenshot 2025-01-23 at 7 58 42 PM

Screenshot 2025-01-23 at 7 58 49 PM

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 24, 2025 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 87.9% 4157 / 4729
🔵 Statements 87.38% 4531 / 5185
🔵 Functions 79.21% 1231 / 1554
🔵 Branches 72.45% 2031 / 2803
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
lib/lambda/sinkChangelog.ts 95.91% 90.9% 100% 97.91% 122, 133
lib/lambda/sinkMainProcessors.ts 100% 100% 100% 100%
lib/lambda/update/adminChangeSchemas.ts 93.33% 100% 83.33% 100% 77-84
lib/lambda/update/submitNOSO.ts 100% 81.25% 100% 100%
lib/packages/shared-types/opensearch/changelog/index.ts 100% 100% 100% 100%
lib/packages/shared-types/opensearch/main/index.ts 100% 100% 100% 100%
react-app/src/features/forms/post-submission/upload-subsequent-documents/index.tsx 72.97% 56.66% 88.88% 72.97% 22, 69, 77-88, 109, 154
react-app/src/features/package/admin-changes/index.tsx 31.57% 0% 0% 35.29% 54-67, 88-91
Generated in workflow #1798 for commit c684300 by the Vitest Coverage Report Action

@andieswift andieswift mentioned this pull request Jan 24, 2025
Closed
@andieswift andieswift self-assigned this Jan 24, 2025
@andieswift andieswift temporarily deployed to admin-noso2-kibana January 24, 2025 04:08 — with GitHub Actions Inactive
@andieswift andieswift marked this pull request as ready for review January 24, 2025 15:43
@asharonbaltazar asharonbaltazar self-requested a review January 24, 2025 16:39
asharonbaltazar
asharonbaltazar requested changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@asharonbaltazar asharonbaltazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work - I have mostly nitpicks, but some feedback should be applied

lib/lambda/update/submitNOSO.ts Outdated Show resolved Hide resolved
lib/lambda/update/submitNOSO.ts Outdated Show resolved Hide resolved
lib/lambda/update/submitNOSO.ts Outdated Show resolved Hide resolved
lib/lambda/update/submitNOSO.ts Outdated Show resolved Hide resolved
lib/lambda/update/adminChangeSchemas.ts Outdated Show resolved Hide resolved
lib/lambda/update/submitNOSO.ts Outdated Show resolved Hide resolved
lib/lambda/update/submitNOSO.ts Show resolved Hide resolved
@andieswift andieswift temporarily deployed to admin-noso2-kibana January 24, 2025 19:16 — with GitHub Actions Inactive
@andieswift andieswift temporarily deployed to admin-noso2-kibana January 28, 2025 23:36 — with GitHub Actions Inactive
@andieswift andieswift temporarily deployed to admin-noso2-kibana January 29, 2025 16:52 — with GitHub Actions Inactive
@andieswift andieswift deployed to admin-noso2 January 29, 2025 17:28 — with GitHub Actions Active
@andieswift andieswift merged commit a1f4e7f into main Jan 29, 2025
15 checks passed
@andieswift andieswift deleted the admin-noso2 branch January 29, 2025 17:33
@github-actions GitHub Actions
Copy link
Contributor

🎉 This PR is included in version 1.5.0-val.119 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asharonbaltazar asharonbaltazar asharonbaltazar approved these changes

Assignees

@andieswift andieswift

Labels
released on @val
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andieswift @asharonbaltazar